Skip to content

Conversation

@munjal-gc
Copy link

Default project deployment is having wrong port mapping of 8080. Node application runs on port 3000.

This PR will fix - front-end-deployment when initial setup is done...

@netlify
Copy link

netlify bot commented Nov 14, 2025

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dd1bcb6
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/691707c3f5f70b00081e4acc
😎 Deploy Preview https://deploy-preview-6501--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow
Copy link

knative-prow bot commented Nov 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: munjal-gc
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

CLA Not Signed

@knative-prow
Copy link

knative-prow bot commented Nov 14, 2025

Welcome @munjal-gc! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 14, 2025
@munjal-gc
Copy link
Author

munjal-gc commented Nov 14, 2025 via email

@dprotaso
Copy link
Member

The Dockerfile has PORT enviroment variable set to 8080 which I believe next.js will use

Thus I think the configuration is correct - though if you're running the server locally I think it will use the local port 3000 because we haven't updated the package.json

@munjal-gc
Copy link
Author

make sense so issue may be in latest image uploaded at ghcr.io/knative/bookstore-frontend:latest
which may not have been built / published post above chances...

@dprotaso
Copy link
Member

Looks like our CI has an issue and the latest changes weren't pushed maybe

eg. https://github.com/knative/docs/actions/runs/19432715858/job/55595454488

let me fix this

@dprotaso
Copy link
Member

I have a PR out here: #6508

@dprotaso dprotaso mentioned this pull request Nov 17, 2025
@cdsre
Copy link

cdsre commented Nov 17, 2025

Nice catch with this one. I have just started the E2E tutorial and faced this issue too. for now I have changed the port mapping locally.

@dprotaso
Copy link
Member

Ok new images are out - can folks try it out?

@dprotaso
Copy link
Member

I think what's left is if you want to update the package.json to change the local port to 8080 I'd be ok with that.

Otherwise I think we can close out the PR

@munjal-gc
Copy link
Author

I think we are good to close the PR as root cause of the issue is addressed...

Thanks for propmtly addressing same.

@munjal-gc munjal-gc closed this Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants