-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fixed port mapping. #6501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed port mapping. #6501
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: munjal-gc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
Welcome @munjal-gc! It looks like this is your first PR to knative/docs 🎉 |
|
Yes, this first PR as we are trying out the quickstart and bumped in to
this issue.
|
|
The Dockerfile has
Thus I think the configuration is correct - though if you're running the server locally I think it will use the local port |
|
make sense so issue may be in latest image uploaded at ghcr.io/knative/bookstore-frontend:latest |
|
Looks like our CI has an issue and the latest changes weren't pushed maybe eg. https://github.com/knative/docs/actions/runs/19432715858/job/55595454488 let me fix this |
|
I have a PR out here: #6508 |
|
Nice catch with this one. I have just started the E2E tutorial and faced this issue too. for now I have changed the port mapping locally. |
|
Ok new images are out - can folks try it out? |
|
I think what's left is if you want to update the package.json to change the local port to 8080 I'd be ok with that. Otherwise I think we can close out the PR |
|
I think we are good to close the PR as root cause of the issue is addressed... Thanks for propmtly addressing same. |
Default project deployment is having wrong port mapping of 8080. Node application runs on port 3000.
This PR will fix - front-end-deployment when initial setup is done...